Skip to content

perf: rm buildinfo on demand #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2024
Merged

perf: rm buildinfo on demand #495

merged 2 commits into from
Nov 29, 2024

Conversation

@Timeless0911
Copy link
Contributor

@Timeless0911 Timeless0911 commented Nov 29, 2024 •
edited
Loading

Summary

only remove buildinfo when composite or incremental is set or dts.build is set to true

Related Links

closes: #493

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Timeless0911
Copy link
Contributor Author

Timeless0911 commented Nov 29, 2024

!benchmark

@rspack-bot
Copy link

rspack-bot commented Nov 29, 2024 •
edited
Loading

📝 Benchmark detail: Open

case: rslib-node-basic
base: 37bc7ee
current: 1e7247f

Metric Base Current %
beforeBuildTime 0.71s 0.7s -1.13%
buildEsmJsTime 0.07s 0.07s -2.55%
esmBundleSize 0.83KB 0.83KB 0.00%
esmGzipBundleSize 0.34KB 0.34KB 0.00%
buildEsmTotalTime 1.35s 1.33s -1.48%
buildCjsJsTime 0.06s 0.07s +6.65%
cjsBundleSize 2.43KB 2.43KB 0.00%
cjsGzipBundleSize 0.8KB 0.8KB 0.00%
buildCjsTotalTime 1.35s 1.33s -1.48%
coldInstallTime 16.83s 13s -22.74%
hotInstallTime 0.25s 0.25s -0.03%
dependenciesCount 112 112 0.00%
installSize 102MB 102MB 0.00%

case: rslib-react-basic
base: 37bc7ee
current: 1e7247f

Metric Base Current %
beforeBuildTime 0.72s 0.7s -1.62%
buildEsmJsTime 0.07s 0.07s +7.80%
esmBundleSize 1.43KB 1.43KB 0.00%
esmGzipBundleSize 0.43KB 0.43KB 0.00%
buildEsmTotalTime 1.52s 1.5s -1.31%
buildCjsJsTime 0.08s 0.06s -18.50%
cjsBundleSize 2.88KB 2.88KB 0.00%
cjsGzipBundleSize 0.85KB 0.85KB 0.00%
buildCjsTotalTime 1.52s 1.5s -1.31%
coldInstallTime 12.72s 9.92s -22.05%
hotInstallTime 0.24s 0.24s +0.68%
dependenciesCount 42 42 0.00%
installSize 77.84MB 77.84MB +0.01%

@Timeless0911
Copy link
Contributor Author

Timeless0911 commented Nov 29, 2024

!benchmark

@rspack-bot
Copy link

rspack-bot commented Nov 29, 2024 •
edited
Loading

📝 Benchmark detail: Open

case: rslib-node-basic
base: 37bc7ee
current: 04790bb

Metric Base Current %
beforeBuildTime 0.71s 0.71s -0.11%
buildEsmJsTime 0.07s 0.06s -9.94%
esmBundleSize 0.83KB 0.83KB 0.00%
esmGzipBundleSize 0.34KB 0.34KB 0.00%
buildEsmTotalTime 1.35s 1.32s -2.35%
buildCjsJsTime 0.06s 0.07s +11.05%
cjsBundleSize 2.43KB 2.43KB 0.00%
cjsGzipBundleSize 0.8KB 0.8KB 0.00%
buildCjsTotalTime 1.35s 1.32s -2.34%
coldInstallTime 16.83s 14.53s -13.67%
hotInstallTime 0.25s 0.26s +0.59%
dependenciesCount 112 112 0.00%
installSize 102MB 102MB 0.00%

case: rslib-react-basic
base: 37bc7ee
current: 04790bb

Metric Base Current %
beforeBuildTime 0.72s 0.71s -0.64%
buildEsmJsTime 0.07s 0.07s +11.87%
esmBundleSize 1.43KB 1.43KB 0.00%
esmGzipBundleSize 0.43KB 0.43KB 0.00%
buildEsmTotalTime 1.52s 1.49s -1.88%
buildCjsJsTime 0.08s 0.07s -9.03%
cjsBundleSize 2.88KB 2.88KB 0.00%
cjsGzipBundleSize 0.85KB 0.85KB 0.00%
buildCjsTotalTime 1.52s 1.49s -1.89%
coldInstallTime 12.72s 10.57s -16.89%
hotInstallTime 0.24s 0.24s -0.16%
dependenciesCount 42 42 0.00%
installSize 77.84MB 77.84MB 0.00%

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 29, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #495 will not alter performance

Comparing perf/delete (c61857e) with main (37bc7ee)

Summary

✅ 5 untouched benchmarks

@Timeless0911
Copy link
Contributor Author

Timeless0911 commented Nov 29, 2024

!benchmark

@Timeless0911 Timeless0911 changed the title chore: update perf: rm buildinfo on demand Nov 29, 2024
@rspack-bot
Copy link

rspack-bot commented Nov 29, 2024 •
edited
Loading

📝 Benchmark detail: Open

case: rslib-node-basic
base: 37bc7ee
current: 40ec8a2

Metric Base Current %
beforeBuildTime 0.71s 0.71s -0.78%
buildEsmJsTime 0.07s 0.06s -7.35%
esmBundleSize 0.83KB 0.83KB 0.00%
esmGzipBundleSize 0.34KB 0.34KB 0.00%
buildEsmTotalTime 1.35s 1.31s -2.74%
buildCjsJsTime 0.06s 0.07s +3.19%
cjsBundleSize 2.43KB 2.43KB 0.00%
cjsGzipBundleSize 0.8KB 0.8KB 0.00%
buildCjsTotalTime 1.35s 1.31s -2.74%
coldInstallTime 16.83s 16.59s -1.42%
hotInstallTime 0.25s 0.25s -0.76%
dependenciesCount 112 112 0.00%
installSize 102MB 102MB 0.00%

case: rslib-react-basic
base: 37bc7ee
current: 40ec8a2

Metric Base Current %
beforeBuildTime 0.72s 0.71s -1.52%
buildEsmJsTime 0.07s 0.06s -8.98%
esmBundleSize 1.43KB 1.43KB 0.00%
esmGzipBundleSize 0.43KB 0.43KB 0.00%
buildEsmTotalTime 1.52s 1.48s -2.62%
buildCjsJsTime 0.08s 0.07s -6.33%
cjsBundleSize 2.88KB 2.88KB 0.00%
cjsGzipBundleSize 0.85KB 0.85KB 0.00%
buildCjsTotalTime 1.52s 1.48s -2.62%
coldInstallTime 12.72s 11.18s -12.11%
hotInstallTime 0.24s 0.24s +0.79%
dependenciesCount 42 42 0.00%
installSize 77.84MB 77.84MB 0.00%

@Timeless0911
Copy link
Contributor Author

Timeless0911 commented Nov 29, 2024

!benchmark

@rspack-bot
Copy link

rspack-bot commented Nov 29, 2024 •
edited
Loading

📝 Benchmark detail: Open

case: rslib-node-basic
base: 37bc7ee
current: a872946

Metric Base Current %
beforeBuildTime 0.71s 0.71s -0.94%
buildEsmJsTime 0.07s 0.06s -8.88%
esmBundleSize 0.83KB 0.83KB 0.00%
esmGzipBundleSize 0.34KB 0.34KB 0.00%
buildEsmTotalTime 1.35s 1.33s -1.34%
buildCjsJsTime 0.06s 0.07s +14.33%
cjsBundleSize 2.43KB 2.43KB 0.00%
cjsGzipBundleSize 0.8KB 0.8KB 0.00%
buildCjsTotalTime 1.35s 1.33s -1.34%
coldInstallTime 16.83s 18.6s +10.54%
hotInstallTime 0.25s 0.25s -1.28%
dependenciesCount 112 112 0.00%
installSize 102MB 102MB 0.00%

case: rslib-react-basic
base: 37bc7ee
current: a872946

Metric Base Current %
beforeBuildTime 0.72s 0.71s -0.62%
buildEsmJsTime 0.07s 0.06s -8.27%
esmBundleSize 1.43KB 1.43KB 0.00%
esmGzipBundleSize 0.43KB 0.43KB 0.00%
buildEsmTotalTime 1.52s 1.48s -2.24%
buildCjsJsTime 0.08s 0.07s -3.01%
cjsBundleSize 2.88KB 2.88KB 0.00%
cjsGzipBundleSize 0.85KB 0.85KB 0.00%
buildCjsTotalTime 1.52s 1.49s -2.25%
coldInstallTime 12.72s 10.94s -14.03%
hotInstallTime 0.24s 0.24s +1.86%
dependenciesCount 42 42 0.00%
installSize 77.84MB 77.84MB 0.00%

@Timeless0911
Copy link
Contributor Author

Timeless0911 commented Nov 29, 2024

!benchmark

@rspack-bot
Copy link

rspack-bot commented Nov 29, 2024 •
edited
Loading

📝 Benchmark detail: Open

case: rslib-node-basic
base: 37bc7ee
current: c61857e

Metric Base Current %
beforeBuildTime 0.71s 0.71s -0.86%
buildEsmJsTime 0.07s 0.05s -21.23%
esmBundleSize 0.83KB 0.83KB 0.00%
esmGzipBundleSize 0.34KB 0.34KB 0.00%
buildEsmTotalTime 1.35s 1.32s -2.37%
buildCjsJsTime 0.06s 0.06s +0.51%
cjsBundleSize 2.43KB 2.43KB 0.00%
cjsGzipBundleSize 0.8KB 0.8KB 0.00%
buildCjsTotalTime 1.35s 1.32s -2.37%
coldInstallTime 16.83s 19.32s +14.84%
hotInstallTime 0.25s 0.25s -1.12%
dependenciesCount 112 112 0.00%
installSize 102MB 102MB 0.00%

case: rslib-react-basic
base: 37bc7ee
current: c61857e

Metric Base Current %
beforeBuildTime 0.72s 0.71s -1.33%
buildEsmJsTime 0.07s 0.06s -14.65%
esmBundleSize 1.43KB 1.43KB 0.00%
esmGzipBundleSize 0.43KB 0.43KB 0.00%
buildEsmTotalTime 1.52s 1.48s -2.83%
buildCjsJsTime 0.08s 0.07s -12.09%
cjsBundleSize 2.88KB 2.88KB 0.00%
cjsGzipBundleSize 0.85KB 0.85KB 0.00%
buildCjsTotalTime 1.52s 1.48s -2.83%
coldInstallTime 12.72s 11.49s -9.69%
hotInstallTime 0.24s 0.24s +2.24%
dependenciesCount 42 42 0.00%
installSize 77.84MB 77.84MB 0.00%

@Timeless0911 Timeless0911 marked this pull request as ready for review November 29, 2024 05:29
@Timeless0911 Timeless0911 merged commit c233f2d into main Nov 29, 2024
18 checks passed
@Timeless0911 Timeless0911 deleted the perf/delete branch November 29, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fi3ework fi3ework fi3ework approved these changes

Assignees

No one assigned

Labels

change: perf

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Benchmark Performance Degradation (2024-11-29)

4 participants

@Timeless0911 @rspack-bot @fi3ework